-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving from zlib to minizlib #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will see if this works against the SPA before merging this PR
@@ -59,5 +59,5 @@ test('v1, compressed, acars, incomplete', () => { | |||
expect(decodeResult.message.data.acars.label).toBe('H1'); | |||
expect(decodeResult.message.data.acars.sublabel).toBe('DF'); | |||
expect(decodeResult.message.data.acars.mfi).toBe(undefined); | |||
expect(decodeResult.message.data.acars.text).toBe(undefined); | |||
expect(decodeResult.message.data.acars.text).toBe('A350,000130,1,1,TB000000/REP019,24,02;H01,019,24,02,6400,00175,B-18910,3,0,03,11,19,08,07,01,070/H02,NZAA YBBN,CAL054 ,S'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andermatt64 added you because i wanted to make sure this is ok... i think it is, but i'm not going to pretend to know this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used
Will keep open as the partial decoding might be good, but if this is closed, i won't be sad |
Ahh worth a try. Hopefully we can figure that out sooner than later. |
@makrsmark What do you think? Is this still up to date? :) |
I think it's useful as it seems to decode a little more. If we want it, I can fix conflicts. Otherwise, we can just close without merging. |
I'd say we merge it (after resolving conflicts), if you still think there is value here. |
No description provided.